Date:2010-11-10 11:26:44 (13 years 4 months ago)
Author:Lars C.
Commit:c69da0250277f2cd4cbb667dd0bc903f495f68dd
Message:POWER: jz4740-battery: Check if platform_data is supplied

Currently platform_data is dereferenced without checking whether it is actually
set, which can lead to kernel crashes.
This patch adds a check which will abort the drivers probe function gracefully
if no platform_data is supplied.

Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
Files: drivers/power/jz4740-battery.c (1 diff)

Change Details

drivers/power/jz4740-battery.c
246246    struct jz_battery *jz_battery;
247247    struct power_supply *battery;
248248
249    if (!pdata) {
250        dev_err(&pdev->dev, "No platform_data supplied\n");
251        return -ENXIO;
252    }
253
249254    jz_battery = kzalloc(sizeof(*jz_battery), GFP_KERNEL);
250255    if (!jz_battery) {
251256        dev_err(&pdev->dev, "Failed to allocate driver structure\n");

Archive Download the corresponding diff file



interactive